Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/bots/compiler.py

Issue 14943007: Only use --use_browser_controller on browsers (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 22771)
+++ tools/bots/compiler.py (working copy)
@@ -144,7 +144,8 @@
cmd.extend(['--progress=buildbot', '-v'])
# TODO(ricow): temporary hack to run on fyi with --use_browser_controller
- if os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main":
+ if (os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and
+ (runtime == 'drt' or runtime == firefox)):
kustermann 2013/05/16 11:38:47 firefox -> 'firefox'
cmd.append('--use_browser_controller')
global IsFirstTestStepCall
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698