Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tools/bots/compiler.py

Issue 14943007: Only use --use_browser_controller on browsers (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
4 # for details. All rights reserved. Use of this source code is governed by a 4 # for details. All rights reserved. Use of this source code is governed by a
5 # BSD-style license that can be found in the LICENSE file. 5 # BSD-style license that can be found in the LICENSE file.
6 6
7 """ 7 """
8 Dart2js buildbot steps 8 Dart2js buildbot steps
9 9
10 Runs tests for the dart2js compiler. 10 Runs tests for the dart2js compiler.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 # TODO(ricow/kustermann): Issue 7339 137 # TODO(ricow/kustermann): Issue 7339
138 if runtime == "safari": 138 if runtime == "safari":
139 cmd.append('--nobatch') 139 cmd.append('--nobatch')
140 140
141 if user_test == 'yes': 141 if user_test == 'yes':
142 cmd.append('--progress=color') 142 cmd.append('--progress=color')
143 else: 143 else:
144 cmd.extend(['--progress=buildbot', '-v']) 144 cmd.extend(['--progress=buildbot', '-v'])
145 145
146 # TODO(ricow): temporary hack to run on fyi with --use_browser_controller 146 # TODO(ricow): temporary hack to run on fyi with --use_browser_controller
147 if os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main": 147 if (os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and
148 (runtime == 'drt' or runtime == firefox)):
kustermann 2013/05/16 11:38:47 firefox -> 'firefox'
148 cmd.append('--use_browser_controller') 149 cmd.append('--use_browser_controller')
149 150
150 global IsFirstTestStepCall 151 global IsFirstTestStepCall
151 if IsFirstTestStepCall: 152 if IsFirstTestStepCall:
152 IsFirstTestStepCall = False 153 IsFirstTestStepCall = False
153 else: 154 else:
154 cmd.append('--append_logs') 155 cmd.append('--append_logs')
155 156
156 if flags: 157 if flags:
157 cmd.extend(flags) 158 cmd.extend(flags)
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 """ 330 """
330 with bot.BuildStep('Build SDK and d8'): 331 with bot.BuildStep('Build SDK and d8'):
331 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode, 332 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
332 'dart2js_bot'] 333 'dart2js_bot']
333 print 'Build SDK and d8: %s' % (' '.join(args)) 334 print 'Build SDK and d8: %s' % (' '.join(args))
334 bot.RunProcess(args) 335 bot.RunProcess(args)
335 336
336 337
337 if __name__ == '__main__': 338 if __name__ == '__main__':
338 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler) 339 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698