Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4213)

Unified Diff: chrome/chrome_features.gypi

Issue 1494253003: MD Downloads: add a use_vulcanize option to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert common.gypi change Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_features.gypi
diff --git a/chrome/chrome_features.gypi b/chrome/chrome_features.gypi
index 06488b1e8afce75d860df7a074cc4dcb72734685..042e43abe98a164cf16ab45d47a4c6039fc78a17 100644
--- a/chrome/chrome_features.gypi
+++ b/chrome/chrome_features.gypi
@@ -21,17 +21,21 @@
'enable_google_now%': 1,
}]
],
+
+ 'use_vulcanize%': 1,
Nico 2015/12/30 14:29:22 shouldn't this default to 0?
Dan Beam 2015/12/30 17:11:12 no
Dan Beam 2015/12/30 17:22:53 i only asked you to review part of this CL, so you
},
# Anything in the conditions needs to be copied to the outer scope to be
# accessible.
'enable_google_now%': '<(enable_google_now)',
'android_java_ui%': '<(android_java_ui)',
+ 'use_vulcanize%': '<(use_vulcanize)',
# Grit defines based on the feature flags. These must be manually added to
# grit targets.
'chrome_grit_defines': [
'-D', 'enable_google_now=<(enable_google_now)',
+ '-D', 'use_vulcanize=<(use_vulcanize)',
]
},
}
« no previous file with comments | « chrome/chrome_features.gyp ('k') | chrome/common/BUILD.gn » ('j') | chrome/common/features.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698