Source/core/html/forms/RangeInputType.cpp - Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/RangeInputType.cpp

Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/RangeInputType.cpp

diff --git a/Source/core/html/forms/RangeInputType.cpp b/Source/core/html/forms/RangeInputType.cpp

index c2358d33763651eea7ebeaab0e2ed06f05d1a545..55066fcc48871707f8d234f19cac199c48c9d8ab 100644

--- a/Source/core/html/forms/RangeInputType.cpp

+++ b/Source/core/html/forms/RangeInputType.cpp

@@ -105,9 +105,9 @@ double RangeInputType::valueAsDouble() const

return parseToDoubleForNumberType(element().value());

}

-void RangeInputType::setValueAsDecimal(const Decimal& newValue, TextFieldEventBehavior eventBehavior, ExceptionState&) const

+void RangeInputType::setValueAsDouble(double newValue, TextFieldEventBehavior eventBehavior, ExceptionState& exceptionState) const

{

- element().setValue(serialize(newValue), eventBehavior);

+ setValueAsDecimal(Decimal::fromDouble(newValue), eventBehavior, exceptionState);

}

bool RangeInputType::typeMismatchFor(const String& value) const

« Source/core/html/forms/BaseDateAndTimeInputType.cpp ('K') | « Source/core/html/forms/RangeInputType.h ('k') | no next file » | no next file with comments »