Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mus.cc

Issue 1493823002: mustash: Remove NOTREACHED() so navigation does not crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mus.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_mus.cc b/content/browser/renderer_host/render_widget_host_view_mus.cc
index 8a12e156e7579eebcb81a6de935a2804f4a0e5a9..c572b06b502953aa7321dac6d39091f729347756 100644
--- a/content/browser/renderer_host/render_widget_host_view_mus.cc
+++ b/content/browser/renderer_host/render_widget_host_view_mus.cc
@@ -202,7 +202,8 @@ void RenderWidgetHostViewMus::CopyFromCompositingSurface(
const gfx::Size& /* dst_size */,
const ReadbackRequestCallback& callback,
const SkColorType /* preferred_color_type */) {
- NOTREACHED();
+ // TODO(fsamuel): Implement read back.
+ // We don't DCHECK here because that would cause navigation to crash.
sadrul 2015/12/02 18:37:11 I don't think this comment is necessary. Maybe rep
Fady Samuel 2015/12/03 17:10:30 Done.
callback.Run(SkBitmap(), READBACK_FAILED);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698