Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_mus.cc

Issue 1493823002: mustash: Remove NOTREACHED() so navigation does not crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_mus.h" 5 #include "content/browser/renderer_host/render_widget_host_view_mus.h"
6 6
7 #include "components/mus/public/cpp/window.h" 7 #include "components/mus/public/cpp/window.h"
8 #include "components/mus/public/cpp/window_tree_connection.h" 8 #include "components/mus/public/cpp/window_tree_connection.h"
9 #include "content/browser/mojo/mojo_shell_client_host.h" 9 #include "content/browser/mojo/mojo_shell_client_host.h"
10 #include "content/browser/renderer_host/render_process_host_impl.h" 10 #include "content/browser/renderer_host/render_process_host_impl.h"
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 195
196 void RenderWidgetHostViewMus::SetBackgroundColor(SkColor color) { 196 void RenderWidgetHostViewMus::SetBackgroundColor(SkColor color) {
197 // TODO(fsamuel): Implement background color and opacity. 197 // TODO(fsamuel): Implement background color and opacity.
198 } 198 }
199 199
200 void RenderWidgetHostViewMus::CopyFromCompositingSurface( 200 void RenderWidgetHostViewMus::CopyFromCompositingSurface(
201 const gfx::Rect& /* src_subrect */, 201 const gfx::Rect& /* src_subrect */,
202 const gfx::Size& /* dst_size */, 202 const gfx::Size& /* dst_size */,
203 const ReadbackRequestCallback& callback, 203 const ReadbackRequestCallback& callback,
204 const SkColorType /* preferred_color_type */) { 204 const SkColorType /* preferred_color_type */) {
205 NOTREACHED(); 205 // TODO(fsamuel): Implement read back.
206 // We don't DCHECK here because that would cause navigation to crash.
sadrul 2015/12/02 18:37:11 I don't think this comment is necessary. Maybe rep
Fady Samuel 2015/12/03 17:10:30 Done.
206 callback.Run(SkBitmap(), READBACK_FAILED); 207 callback.Run(SkBitmap(), READBACK_FAILED);
207 } 208 }
208 209
209 void RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame( 210 void RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame(
210 const gfx::Rect& src_subrect, 211 const gfx::Rect& src_subrect,
211 const scoped_refptr<media::VideoFrame>& target, 212 const scoped_refptr<media::VideoFrame>& target,
212 const base::Callback<void(const gfx::Rect&, bool)>& callback) { 213 const base::Callback<void(const gfx::Rect&, bool)>& callback) {
213 NOTIMPLEMENTED(); 214 NOTIMPLEMENTED();
214 callback.Run(gfx::Rect(), false); 215 callback.Run(gfx::Rect(), false);
215 } 216 }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 void RenderWidgetHostViewMus::SetParentNativeViewAccessible( 302 void RenderWidgetHostViewMus::SetParentNativeViewAccessible(
302 gfx::NativeViewAccessible accessible_parent) {} 303 gfx::NativeViewAccessible accessible_parent) {}
303 304
304 gfx::NativeViewId RenderWidgetHostViewMus::GetParentForWindowlessPlugin() 305 gfx::NativeViewId RenderWidgetHostViewMus::GetParentForWindowlessPlugin()
305 const { 306 const {
306 return gfx::NativeViewId(); 307 return gfx::NativeViewId();
307 } 308 }
308 #endif 309 #endif
309 310
310 } // namespace content 311 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698