mustash: Remove NOTREACHED() so navigation does not crash

mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none

Committed: https://crrev.com/52ff65b5af54774799d9182ab0ee6881bb2872a7
Cr-Commit-Position: refs/heads/master@{#363014}

[Fady Samuel, 2015-12-02 18:31:21]

Description was changed from

==========
mustash: Remove NOTREACHED() so navigation does not crash


RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none
==========

to

==========
mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none
==========

[Fady Samuel, 2015-12-02 18:31:28]

fsamuel@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2015-12-02 18:37:11]

lgtm

https://codereview.chromium.org/1493823002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mus.cc (right):

https://codereview.chromium.org/1493823002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mus.cc:206: // We don't
DCHECK here because that would cause navigation to crash.
I don't think this comment is necessary. Maybe replace with a NOTIMPLEMENTED()
instead.

[Fady Samuel, 2015-12-03 17:10:30]

CQ'ing.

https://codereview.chromium.org/1493823002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mus.cc (right):

https://codereview.chromium.org/1493823002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mus.cc:206: // We don't
DCHECK here because that would cause navigation to crash.
On 2015/12/02 18:37:11, sadrul wrote:
> I don't think this comment is necessary. Maybe replace with a NOTIMPLEMENTED()
> instead.

Done.

[Fady Samuel, 2015-12-03 17:10:32]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-12-03 17:10:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1493823002/#ps20001
(title: "Addressed Sadrul's comment")

[commit-bot: I haz the power, 2015-12-03 17:10:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493823002/20001

[commit-bot: I haz the power, 2015-12-03 18:31:32]

Description was changed from

==========
mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none
==========

to

==========
mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none
==========

[commit-bot: I haz the power, 2015-12-03 18:31:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 18:33:17]

Description was changed from

==========
mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none
==========

to

==========
mustash: Remove NOTREACHED() so navigation does not crash

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a
NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none

Committed: https://crrev.com/52ff65b5af54774799d9182ab0ee6881bb2872a7
Cr-Commit-Position: refs/heads/master@{#363014}
==========

[commit-bot: I haz the power, 2015-12-03 18:33:18]

Patchset 2 (id:??) landed as
https://crrev.com/52ff65b5af54774799d9182ab0ee6881bb2872a7
Cr-Commit-Position: refs/heads/master@{#363014}