tools/clang/plugins/FindBadConstructsConsumer.h - Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.h

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/FindBadConstructsConsumer.h

diff --git a/tools/clang/plugins/FindBadConstructsConsumer.h b/tools/clang/plugins/FindBadConstructsConsumer.h

index 8f8fc87046630911ac93ae59995da6d5c8ca8a68..c0618a82291c5d3af3f65e76bf6e3d6fa2407979 100644

--- a/tools/clang/plugins/FindBadConstructsConsumer.h

+++ b/tools/clang/plugins/FindBadConstructsConsumer.h

@@ -72,10 +72,8 @@ class FindBadConstructsConsumer

unsigned diagnostic_id);

void CheckVirtualMethods(clang::SourceLocation record_location,

- clang::CXXRecordDecl* record,

- bool warn_on_inline_bodies);

+ clang::CXXRecordDecl* record);

void CheckVirtualSpecifiers(const clang::CXXMethodDecl* method);

- void CheckVirtualBodies(const clang::CXXMethodDecl* method);

void CountType(const clang::Type* type,

int* trivial_member,