Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/FindBadConstructsAction.cpp
diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
index 443eecc6884a4ba9fb540ef9d585a93706bd6d55..0320d2b1116740bb2047d965107ff4400afc7b32 100644
--- a/tools/clang/plugins/FindBadConstructsAction.cpp
+++ b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -61,6 +61,10 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
options_.check_templates = true;
} else if (args[i] == "follow-macro-expansion") {
options_.follow_macro_expansion = true;
+ } else if (args[i] == "treat-virtuals-as-complexity") {
+ // TODO(jyasskin): Enable this by default once https://crbug.com/565523 is
+ // fixed.
+ options_.treat_virtuals_as_complexity = true;
} else {
parsed = false;
llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.h » ('j') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698