Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1493753004: GN: Make compiler invocations for Non-SFI ARM NaCl consistent with Gyp build (Closed)

Created:
5 years ago by Mark Seaborn
Modified:
5 years ago
Reviewers:
Dirk Pranke, Sam Clegg
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make compiler invocations for Non-SFI ARM NaCl consistent with Gyp build The Gyp build uses "--target=armv7-unknown-nacl-gnueabihf" (via native_client/build/untrusted.gypi) and passes this argument at link time too. BUG=564059 TEST=none Committed: https://crrev.com/9dd9c7199e1eb64d964d34d0e90dffb3f0439df5 Cr-Commit-Position: refs/heads/master@{#363110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Mark Seaborn
This is a correction to https://codereview.chromium.org/1489193002. I haven't tested it, though. Is there a trybot ...
5 years ago (2015-12-03 19:57:24 UTC) #2
Sam Clegg
On 2015/12/03 19:57:24, Mark Seaborn wrote: > This is a correction to https://codereview.chromium.org/1489193002. I haven't ...
5 years ago (2015-12-03 20:07:11 UTC) #3
Dirk Pranke
rubber-stamp lgtm :)
5 years ago (2015-12-03 22:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493753004/1
5 years ago (2015-12-03 22:28:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
5 years ago (2015-12-04 00:39:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493753004/1
5 years ago (2015-12-04 02:14:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 03:54:37 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-04 03:55:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dd9c7199e1eb64d964d34d0e90dffb3f0439df5
Cr-Commit-Position: refs/heads/master@{#363110}

Powered by Google App Engine
This is Rietveld 408576698