Enable arm/linux chromium to build with gn

Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059
Committed: https://crrev.com/84dfa8edd49e6fc2c8f82c8cc53677e5ea52bc08
Cr-Commit-Position: refs/heads/master@{#362820}

[Sam Clegg, 2015-12-02 00:41:05]

Description was changed from

==========
Enable arm/linux chromium to build with gn

BUG=564059
==========

to

==========
Enable arm/linux chromium to build with gn

With this change all arm/linux targets are buildable
with gn.

TEST=ninja -C out/gn_arm/ -j500
BUG=564059
==========

[Sam Clegg, 2015-12-02 00:42:56]

sbc@chromium.org changed reviewers:
+ dpranke@chromium.org, jln@chromium.org

[Sam Clegg, 2015-12-02 00:42:57]

https://codereview.chromium.org/1489193002/diff/1/sandbox/linux/system_header...
File sandbox/linux/system_headers/arm_linux_syscalls.h (right):

https://codereview.chromium.org/1489193002/diff/1/sandbox/linux/system_header...
sandbox/linux/system_headers/arm_linux_syscalls.h:245: #define __NR_getrlimit
(__NR_SYSCALL_BASE+76)
This is defined and then undefined in
debian_wheezy_arm-sysroot/usr/include/arm-linux-gnueabihf/asm/unistd.h with the
following comment:

/*                                                                              

 * The following syscalls are obsolete and no longer available for EABI.        

 */                                                                             

#if defined(__ARM_EABI__) && !defined(__KERNEL__)   
...


So is this the best solution?  Or should I use #ifdef at the use site in
mojo/runner/host/linux_sandbox.cc?

[Dirk Pranke, 2015-12-02 00:44:55]

lgtm. I have no informed opinion on the arm_linux_syscalls.h change.

[Sam Clegg, 2015-12-02 00:56:20]

Description was changed from

==========
Enable arm/linux chromium to build with gn

With this change all arm/linux targets are buildable
with gn.

TEST=ninja -C out/gn_arm/ -j500
BUG=564059
==========

to

==========
Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059
==========

[jln (very slow on Chromium), 2015-12-02 02:05:25]

jln@chromium.org changed reviewers:
+ rickyz@chromium.org

[jln (very slow on Chromium), 2015-12-02 02:08:08]

On 2015/12/02 00:44:55, Dirk Pranke wrote:
> lgtm. I have no informed opinion on the arm_linux_syscalls.h change.

Hmm, I suppose ARM uses prlimit()?

In that case, I suspect the right change is to allow prlimit() if |new_limit| is
NULL in the sandbox.

Rickyz?

[jln (very slow on Chromium), 2015-12-02 02:12:53]

This seems to be blocking something very unrelated. You could #ifdef
__NR_getrlimit in mojo/runner/host/linux_sandbox.cc instead with a TODO() to fix
this on ARM.

[Sam Clegg, 2015-12-02 19:29:41]

On 2015/12/02 02:12:53, jln (slow on Chromium) wrote:
> This seems to be blocking something very unrelated. You could #ifdef
> __NR_getrlimit in mojo/runner/host/linux_sandbox.cc instead with a TODO() to
fix
> this on ARM.

Indeed, that was the way I initial fixed this.  Can you put your name in the
TODO().. seems strange to my mine in there since I almost certainly don't be
fixing it.

[Sam Clegg, 2015-12-02 20:41:00]

sbc@chromium.org changed reviewers:
+ sky@chromium.org

[Sam Clegg, 2015-12-02 20:41:00]

+sky for mojo OWNERS

[sky, 2015-12-02 22:02:18]

LGTM

https://codereview.chromium.org/1489193002/diff/20001/mojo/runner/host/linux_...
File mojo/runner/host/linux_sandbox.cc (right):

https://codereview.chromium.org/1489193002/diff/20001/mojo/runner/host/linux_...
mojo/runner/host/linux_sandbox.cc:86: #ifdef __NR_getrlimit
Use #if defined(...).

[Sam Clegg, 2015-12-02 22:27:01]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-12-02 22:27:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1489193002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-12-02 22:28:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489193002/40001

[commit-bot: I haz the power, 2015-12-02 23:45:52]

Description was changed from

==========
Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059
==========

to

==========
Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059
==========

[commit-bot: I haz the power, 2015-12-02 23:45:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-02 23:46:43]

Description was changed from

==========
Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059
==========

to

==========
Enable arm/linux chromium to build with gn

With this change it is possible to build chromium
for arm/linux using gn.

TEST=ninja -C out/gn_arm/ chrome -j500
BUG=564059

Committed: https://crrev.com/84dfa8edd49e6fc2c8f82c8cc53677e5ea52bc08
Cr-Commit-Position: refs/heads/master@{#362820}
==========

[commit-bot: I haz the power, 2015-12-02 23:46:44]

Patchset 3 (id:??) landed as
https://crrev.com/84dfa8edd49e6fc2c8f82c8cc53677e5ea52bc08
Cr-Commit-Position: refs/heads/master@{#362820}

[Mark Seaborn, 2015-12-03 20:02:18]

mseaborn@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2015-12-03 20:02:18]

https://codereview.chromium.org/1489193002/diff/40001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1489193002/diff/40001/build/config/compiler/B...
build/config/compiler/BUILD.gn:556: "--target=arm-unknown-nacl",
FYI, this doesn't match the Gyp build exactly.  Here's a fix:
https://codereview.chromium.org/1493753004/