Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp

Issue 1493753003: Drop [LegacyInterfaceTypeChecking] for the Web Audio API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp b/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
index 26b2f68dedaa3cf74cb9ea7e9ad78167bb2695a9..6f8b620ee53bd811963e1dfe5fa82ddf15aa825c 100644
--- a/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
@@ -190,9 +190,7 @@ void RealtimeAnalyser::doFFTAnalysis()
void RealtimeAnalyser::getFloatFrequencyData(DOMFloat32Array* destinationArray)
{
ASSERT(isMainThread());
-
- if (!destinationArray)
- return;
+ ASSERT(destinationArray);
doFFTAnalysis();
@@ -215,9 +213,7 @@ void RealtimeAnalyser::getFloatFrequencyData(DOMFloat32Array* destinationArray)
void RealtimeAnalyser::getByteFrequencyData(DOMUint8Array* destinationArray)
{
ASSERT(isMainThread());
-
- if (!destinationArray)
- return;
+ ASSERT(destinationArray);
doFFTAnalysis();
@@ -252,9 +248,7 @@ void RealtimeAnalyser::getByteFrequencyData(DOMUint8Array* destinationArray)
void RealtimeAnalyser::getFloatTimeDomainData(DOMFloat32Array* destinationArray)
{
ASSERT(isMainThread());
-
- if (!destinationArray)
- return;
+ ASSERT(destinationArray);
unsigned fftSize = this->fftSize();
size_t len = std::min(fftSize, destinationArray->length());
@@ -281,9 +275,7 @@ void RealtimeAnalyser::getFloatTimeDomainData(DOMFloat32Array* destinationArray)
void RealtimeAnalyser::getByteTimeDomainData(DOMUint8Array* destinationArray)
{
ASSERT(isMainThread());
-
- if (!destinationArray)
- return;
+ ASSERT(destinationArray);
unsigned fftSize = this->fftSize();
size_t len = std::min(fftSize, destinationArray->length());

Powered by Google App Engine
This is Rietveld 408576698