Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

Issue 1493753003: Drop [LegacyInterfaceTypeChecking] for the Web Audio API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
index e16331e5d228db99a15e54f714fd67c23a6921ff..f4967991e7bafc8d3e735b62a90d4a5745c9d6cd 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
@@ -201,6 +201,7 @@ void AudioParamTimeline::setTargetAtTime(float target, double time, double timeC
void AudioParamTimeline::setValueCurveAtTime(DOMFloat32Array* curve, double time, double duration, ExceptionState& exceptionState)
{
ASSERT(isMainThread());
+ ASSERT(curve);
Raymond Toy 2015/12/04 17:30:42 In a release build, what should we do if curve is
philipj_slow 2015/12/04 18:31:57 Would you like me to revert all changes to cpp fil
Raymond Toy 2015/12/04 21:06:26 Thanks for the info. I think this is fine, plus y
if (!isNonNegativeAudioParamTime(time, exceptionState)
|| !isPositiveAudioParamTime(duration, exceptionState, "Duration"))

Powered by Google App Engine
This is Rietveld 408576698