Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493733002: [debugger] fix liveedit in combination with step in. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] fix liveedit in combination with step in. R=verwaest@chromium.org Committed: https://crrev.com/e1866c8f6fb39981e083bfd698812a90ebb17778 Cr-Commit-Position: refs/heads/master@{#32517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/debug-liveedit-stepin.js View 1 chunk +81 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1491743005 Patch 1

Messages

Total messages: 12 (5 generated)
Yang
5 years ago (2015-12-02 13:06:36 UTC) #1
Toon Verwaest
lgtm
5 years ago (2015-12-02 13:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493733002/1
5 years ago (2015-12-02 13:53:35 UTC) #4
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years ago (2015-12-02 14:17:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493733002/1
5 years ago (2015-12-02 14:25:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:26:45 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 14:27:14 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e1866c8f6fb39981e083bfd698812a90ebb17778
Cr-Commit-Position: refs/heads/master@{#32517}

Powered by Google App Engine
This is Rietveld 408576698