Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491743005: [debugger] do not predict step in target for liveedit. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@liveeditstep
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] do not predict step in target for liveedit. R=verwaest@chromium.org Committed: https://crrev.com/8f87ff5d62e996b07ffbde7e735daa603c1d7290 Cr-Commit-Position: refs/heads/master@{#32553} Committed: https://crrev.com/00559c4584fe3a4c3c1a8d3a5b5af0611b19c40a Cr-Commit-Position: refs/heads/master@{#32600} Committed: https://crrev.com/1e671030b96d48105c00ada463e10d95d73dae24 Cr-Commit-Position: refs/heads/master@{#32614}

Patch Set 1 #

Patch Set 2 : fix crash #

Patch Set 3 : do not prepare stepping if we are not in the debugger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -187 lines) Patch
M src/arm/macro-assembler-arm.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/assembler.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/builtins.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/debug/arm/debug-arm.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 1 chunk +6 lines, -14 lines 0 comments Download
M src/debug/debug.h View 1 4 chunks +1 line, -14 lines 0 comments Download
M src/debug/debug.cc View 1 2 6 chunks +14 lines, -28 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/debug/liveedit.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 8 chunks +10 lines, -33 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 1 chunk +3 lines, -11 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 1 chunk +3 lines, -11 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 1 chunk +3 lines, -11 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
Yang
5 years ago (2015-12-02 14:00:50 UTC) #1
Toon Verwaest
lgtm
5 years ago (2015-12-03 11:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491743005/1
5 years ago (2015-12-03 11:50:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 12:11:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f87ff5d62e996b07ffbde7e735daa603c1d7290 Cr-Commit-Position: refs/heads/master@{#32553}
5 years ago (2015-12-03 12:12:09 UTC) #7
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1494143002/ by machenbach@chromium.org. ...
5 years ago (2015-12-03 13:58:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491743005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491743005/20001
5 years ago (2015-12-04 07:35:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-04 08:52:38 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/00559c4584fe3a4c3c1a8d3a5b5af0611b19c40a Cr-Commit-Position: refs/heads/master@{#32600}
5 years ago (2015-12-04 08:53:01 UTC) #16
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1498523008/ by machenbach@chromium.org. ...
5 years ago (2015-12-04 10:42:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491743005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491743005/40001
5 years ago (2015-12-04 13:02:11 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-04 13:26:03 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-04 13:26:25 UTC) #25
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1e671030b96d48105c00ada463e10d95d73dae24
Cr-Commit-Position: refs/heads/master@{#32614}

Powered by Google App Engine
This is Rietveld 408576698