Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@grid-template-working

Patch Set: Adding checks and layout tests to verify misplaced 'none' arguments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/resources/grid-template-shorthand-parsing-utils.js ('k') | Source/core/css/CSSProperty.cpp » ('j') | Source/core/css/parser/BisonCSSParser-in.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index d6912a5a983dd4b0661811b2176920c670fa8e13..0d5c975fdad0edd97f8d86e773eb251c8c362734 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -1940,6 +1940,9 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert

case CSSPropertyGridArea:

return valuesForGridShorthand(gridAreaShorthand());

Julien - ping for review 2014/02/21 20:04:50 Unneeded empty line.

+ case CSSPropertyGridTemplate:

+ return valuesForGridShorthand(gridTemplateShorthand());

case CSSPropertyGridTemplateAreas:

if (!style->namedGridAreaRowCount()) {

ASSERT(!style->namedGridAreaColumnCount());