Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html

Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@grid-template-working
Patch Set: Adding checks and layout tests to verify misplaced 'none' arguments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html b/LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html
similarity index 86%
copy from LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html
copy to LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html
index b163ce77aca409362c5b80d336e096c20e6092bc..323bb4e491299e8f70819340b43e01a03b94307c 100644
--- a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-template-shorthand-named-grid-line-get-set.html
@@ -15,56 +15,43 @@
width: 77px;
}
.gridWithFixed {
- grid-template-columns: (first) 10px;
- grid-template-rows: (first) 15px;
+ grid-template: (first) 10px / (first) 15px;
}
.gridWithPercent {
- grid-template-columns: 53% (last);
- grid-template-rows: 27% (last);
+ grid-template: 53% (last) / 27% (last);
}
.gridWithAuto {
- grid-template-columns: (first) auto;
- grid-template-rows: auto (last);
+ grid-template: (first) auto / auto (last);
}
.gridWithMinMax {
- grid-template-columns: (first) minmax(10%, 15px);
- grid-template-rows: minmax(20px, 50%) (last);
+ grid-template: (first) minmax(10%, 15px) / minmax(20px, 50%) (last);
}
.gridWithFixedMultiple {
- grid-template-columns: (first nav) 10px (last);
- grid-template-rows: (first nav) 15px (last);
+ grid-template: (first nav) 10px (last) / (first nav) 15px (last);
}
.gridWithPercentageSameStringMultipleTimes {
- grid-template-columns: (first nav) 10% (nav) 15% (last);
- grid-template-rows: (first nav2) 25% (nav2) 75% (last);
+ grid-template: (first nav) 10% (nav) 15% (last) / (first nav2) 25% (nav2) 75% (last);
}
.gridWithRepeat {
- grid-template-columns: (first) 10px repeat(2, (nav nav2) 50%);
- grid-template-rows: 100px repeat(2, (nav nav2) 25%) (last);
+ grid-template: (first) 10px repeat(2, (nav nav2) 50%) / 100px repeat(2, (nav nav2) 25%) (last);
}
.gridWithEmptyParentheses {
- grid-template-columns: () 10px;
- grid-template-rows: 20px ( ) 50px ();
+ grid-template: () 10px / 20px ( ) 50px ();
}
.gridWithoutParentheses {
- grid-template-columns: first nav 10px;
- grid-template-rows: first 50% last;
+ grid-template: first nav 10px / first 50% last;
}
.gridWithInvalidNestedParentheses {
- grid-template-columns: (first (nav)) 10px (last);
- grid-template-rows: (first) 50% (last (nav) nav2);
+ grid-template: (first (nav)) 10px (last) / (first) 50% (last (nav) nav2);
}
.gridWithUnbalancedParentheses {
- grid-template-columns: (first nav 10px;
- grid-template-rows: (first) 50% last);
+ grid-template: (first nav 10px / (first) 50% last);
}
.gridWithMisplacedParentheses {
- grid-template-columns: (first 10px) 50%;
- grid-template-rows: (first) (nav 50%);
+ grid-template: (first 10px) 50% / (first) (nav 50%);
}
.gridWithContiguousParentheses {
- grid-template-columns: (first) (nav) 10px;
- grid-template-rows: 50px (nav nav2) (middle) 10px;
+ grid-template: (first) (nav) 10px / 50px (nav nav2) (middle) 10px;
Julien - ping for review 2014/02/21 20:04:50 I would keep these with the longhands as it's unne
}
</style>
<script src="../../resources/js-test.js"></script>

Powered by Google App Engine
This is Rietveld 408576698