Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493633005: [Release] releases.py should not crash on non-release versions (Closed)

Created:
5 years ago by Michael Hablich
Modified:
5 years ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Release] releases.py should not crash on non-release versions NOTRY=true R=machenbach@chromium.org Committed: https://crrev.com/478d3d6a32046614bba9b74194fdaa80452d568d Cr-Commit-Position: refs/heads/master@{#32545}

Patch Set 1 #

Patch Set 2 : reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/release/releases.py View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
5 years ago (2015-12-03 08:43:10 UTC) #1
Michael Achenbach
lgtm
5 years ago (2015-12-03 08:57:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493633005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493633005/20001
5 years ago (2015-12-03 09:17:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 09:20:48 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-03 09:21:11 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/478d3d6a32046614bba9b74194fdaa80452d568d
Cr-Commit-Position: refs/heads/master@{#32545}

Powered by Google App Engine
This is Rietveld 408576698