Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tools/release/releases.py

Issue 1493633005: [Release] releases.py should not crash on non-release versions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: reformat Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/releases.py
diff --git a/tools/release/releases.py b/tools/release/releases.py
index 5b826fccba089d27afc2f0cab0fefc209ae033af..7b659ccb80693fd4dc4a5009239547b89c49d21a 100755
--- a/tools/release/releases.py
+++ b/tools/release/releases.py
@@ -463,10 +463,15 @@ class RetrieveInformationOnChromeReleases(Step):
def _GetGitHashForV8Version(self, v8_version):
if v8_version == "N/A":
return ""
+
+ real_v8_version = v8_version
if v8_version.split(".")[3]== "0":
- return self.GitGetHashOfTag(v8_version[:-2])
+ real_v8_version = v8_version[:-2]
- return self.GitGetHashOfTag(v8_version)
+ try:
+ return self.GitGetHashOfTag(real_v8_version)
+ except GitFailedException:
+ return ""
def _CreateCandidate(self, current_version):
params = None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698