Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1493553003: Remove SignatureAlgorithm::Equals() and associated functions. (Closed)

Created:
5 years ago by eroman
Modified:
5 years ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, mattm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SignatureAlgorithm::Equals() and associated functions. Will instead test equality directly via byte-for-byte equivalence (with some compatibility hacks for ancient RSA with SHA1 encodings). This follows a suggestion by davidben on https://codereview.chromium.org/1414923007/ BUG=410574 Committed: https://crrev.com/d7af0d061423b93a6952df8e2fa690cc3a1c931e Cr-Commit-Position: refs/heads/master@{#365928}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -138 lines) Patch
M net/cert/internal/signature_algorithm.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/cert/internal/signature_algorithm.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M net/cert/internal/signature_algorithm_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
eroman
5 years ago (2015-12-03 04:36:39 UTC) #2
davidben
Hooray for removing code. lgtm.
5 years ago (2015-12-03 17:29:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493553003/20001
5 years ago (2015-12-17 19:46:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 22:42:32 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-17 22:44:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7af0d061423b93a6952df8e2fa690cc3a1c931e
Cr-Commit-Position: refs/heads/master@{#365928}

Powered by Google App Engine
This is Rietveld 408576698