Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: net/cert/internal/signature_algorithm_unittest.cc

Issue 1493553003: Remove SignatureAlgorithm::Equals() and associated functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/signature_algorithm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/signature_algorithm_unittest.cc
diff --git a/net/cert/internal/signature_algorithm_unittest.cc b/net/cert/internal/signature_algorithm_unittest.cc
index 8cc5517b3e9487a6146cd76c34f2d52f042543af..32f5a0fc62916075f447aeeef9fc5ade5a592c0f 100644
--- a/net/cert/internal/signature_algorithm_unittest.cc
+++ b/net/cert/internal/signature_algorithm_unittest.cc
@@ -485,106 +485,6 @@ TEST(SignatureAlgorithmTest, ParseDerEcdsaWithSHA512NullParams) {
ASSERT_FALSE(ParseDer(kData, &algorithm));
}
-// Tests that two RSA algorithms with different digests are not equal.
-TEST(SignatureAlgorithmTest, EqualsRsaWithDifferentDigest) {
- scoped_ptr<SignatureAlgorithm> alg1 =
- SignatureAlgorithm::CreateRsaPkcs1(DigestAlgorithm::Sha1);
-
- scoped_ptr<SignatureAlgorithm> alg2 =
- SignatureAlgorithm::CreateRsaPkcs1(DigestAlgorithm::Sha256);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
-// Tests that two ECDSA algorithms with different digests are not equal.
-TEST(SignatureAlgorithmTest, EqualsEcdsaWithDifferentDigest) {
- scoped_ptr<SignatureAlgorithm> alg1 =
- SignatureAlgorithm::CreateEcdsa(DigestAlgorithm::Sha1);
-
- scoped_ptr<SignatureAlgorithm> alg2 =
- SignatureAlgorithm::CreateEcdsa(DigestAlgorithm::Sha256);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
-// Tests that an ECDSA algorithm is not equal to an RSA algorithm (even though
-// digests match).
-TEST(SignatureAlgorithmTest, EqualsEcdsaNotEqualRsa) {
- scoped_ptr<SignatureAlgorithm> alg1 =
- SignatureAlgorithm::CreateEcdsa(DigestAlgorithm::Sha256);
-
- scoped_ptr<SignatureAlgorithm> alg2 =
- SignatureAlgorithm::CreateRsaPkcs1(DigestAlgorithm::Sha256);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
-// Tests that two identical ECDSA algorithms are equal - both use SHA-256.
-TEST(SignatureAlgorithmTest, EqualsEcdsaMatch) {
- scoped_ptr<SignatureAlgorithm> alg1 =
- SignatureAlgorithm::CreateEcdsa(DigestAlgorithm::Sha256);
-
- scoped_ptr<SignatureAlgorithm> alg2 =
- SignatureAlgorithm::CreateEcdsa(DigestAlgorithm::Sha256);
-
- ASSERT_TRUE(alg1->Equals(*alg2));
-}
-
-// Tests that two identical RSA algorithms are equal - both use SHA-512
-TEST(SignatureAlgorithmTest, EqualsRsaPkcs1Match) {
- scoped_ptr<SignatureAlgorithm> alg1 =
- SignatureAlgorithm::CreateRsaPkcs1(DigestAlgorithm::Sha512);
-
- scoped_ptr<SignatureAlgorithm> alg2 =
- SignatureAlgorithm::CreateRsaPkcs1(DigestAlgorithm::Sha512);
-
- ASSERT_TRUE(alg1->Equals(*alg2));
-}
-
-// Tests that two RSASSA-PSS algorithms are equal.
-TEST(SignatureAlgorithmTest, EqualsRsaPssMatch) {
- scoped_ptr<SignatureAlgorithm> alg1 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha256, DigestAlgorithm::Sha1, 21);
-
- scoped_ptr<SignatureAlgorithm> alg2 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha256, DigestAlgorithm::Sha1, 21);
-
- ASSERT_TRUE(alg1->Equals(*alg2));
-}
-
-// Tests that two RSASSA-PSS algorithms with different hashes are not equal.
-TEST(SignatureAlgorithmTest, EqualsRsaPssWithDifferentDigest) {
- scoped_ptr<SignatureAlgorithm> alg1 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha1, DigestAlgorithm::Sha1, 20);
-
- scoped_ptr<SignatureAlgorithm> alg2 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha256, DigestAlgorithm::Sha1, 20);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
-// Tests that two RSASSA-PSS algorithms with different mask gens are not equal.
-TEST(SignatureAlgorithmTest, EqualsRsaPssWithDifferentMaskGen) {
- scoped_ptr<SignatureAlgorithm> alg1 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha256, DigestAlgorithm::Sha1, 20);
-
- scoped_ptr<SignatureAlgorithm> alg2 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha256, DigestAlgorithm::Sha256, 20);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
-// Tests that two RSASSA-PSS algorithms with different salts
-TEST(SignatureAlgorithmTest, EqualsRsaPssWithDifferentSalt) {
- scoped_ptr<SignatureAlgorithm> alg1 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha1, DigestAlgorithm::Sha1, 20);
-
- scoped_ptr<SignatureAlgorithm> alg2 = SignatureAlgorithm::CreateRsaPss(
- DigestAlgorithm::Sha1, DigestAlgorithm::Sha1, 16);
-
- ASSERT_FALSE(alg1->Equals(*alg2));
-}
-
// Tests that the parmeters returned for an ECDSA algorithm are null for
// non-ECDSA algorithms.
TEST(SignatureAlgorithmTest, ParamsAreNullForWrongTypeEcdsa) {
« no previous file with comments | « net/cert/internal/signature_algorithm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698