Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1493523003: Reland of [heap] Refactor evacuation for young and old gen into visitors. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Refactor evacuation for young and old gen into visitors. (patchset #1 id:1 of https://codereview.chromium.org/1483393002/ ) Reason for revert: Reland after fixing the potential root cause of the canary crasher. Original issue's description: > Revert of [heap] Refactor evacuation for young and old gen into visitors. (patchset #5 id:80001 of https://codereview.chromium.org/1470253002/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Refactor evacuation for young and old gen into visitors. > > > > Create a visitor for evacuating objects for young and old generation. This is > > the first step of preparing a task to process, both, newspace and oldspace > > pages in parallel. > > > > BUG=chromium:524425 > > LOG=N > > > > Committed: https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 > > Cr-Commit-Position: refs/heads/master@{#32349} > > TBR=mlippautz@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:524425 > > Committed: https://crrev.com/aa24a3135ec308e1f84bce334844caf0cae2437a > Cr-Commit-Position: refs/heads/master@{#32462} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/120b640dfce5f02cecc5af72ca0b2b3b93ce8652 Cr-Commit-Position: refs/heads/master@{#32500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -111 lines) Patch
M src/heap/mark-compact.h View 2 chunks +13 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 6 chunks +122 lines, -106 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Hannes Payer (out of office)
Created Reland of [heap] Refactor evacuation for young and old gen into visitors.
5 years ago (2015-12-02 11:02:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493523003/1
5 years ago (2015-12-02 11:03:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 11:03:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/120b640dfce5f02cecc5af72ca0b2b3b93ce8652 Cr-Commit-Position: refs/heads/master@{#32500}
5 years ago (2015-12-02 11:03:37 UTC) #5
Michael Lippautz
5 years ago (2015-12-02 14:50:05 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1495583002/ by mlippautz@chromium.org.

The reason for reverting is: Speculative revert for crashing Canary..

Powered by Google App Engine
This is Rietveld 408576698