Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1470253002: [heap] Refactor evacuation for young and old gen into visitors. (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Refactor evacuation for young and old gen into visitors. Create a visitor for evacuating objects for young and old generation. This is the first step of preparing a task to process, both, newspace and oldspace pages in parallel. BUG=chromium:524425 LOG=N Committed: https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 Cr-Commit-Position: refs/heads/master@{#32349}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment; Added code comments and DCHECK #

Total comments: 2

Patch Set 3 : Addressed comment #

Patch Set 4 : Rebase #

Patch Set 5 : don't check for WAS_SWEPT, as we never sweep newspace pages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -103 lines) Patch
M src/heap/mark-compact.h View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 6 chunks +114 lines, -98 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Michael Lippautz
PTAL Nothing concurrent happening for newspace as of now.
5 years ago (2015-11-24 15:26:21 UTC) #3
Michael Lippautz
5 years ago (2015-11-24 16:01:11 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1470253002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1470253002/diff/1/src/heap/mark-compact.cc#newcode1644 src/heap/mark-compact.cc:1644: HeapObjectVisitor* visitor, If this method returns a bool indicating ...
5 years ago (2015-11-24 16:07:35 UTC) #6
Michael Lippautz
https://codereview.chromium.org/1470253002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1470253002/diff/1/src/heap/mark-compact.cc#newcode1644 src/heap/mark-compact.cc:1644: HeapObjectVisitor* visitor, On 2015/11/24 16:07:35, Hannes Payer wrote: > ...
5 years ago (2015-11-24 19:19:50 UTC) #7
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1470253002/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1470253002/diff/20001/src/heap/mark-compact.cc#newcode3151 src/heap/mark-compact.cc:3151: IterateLiveObjectsOnPage(p, &new_space_visitor, kClearMarkbits); This one should always return ...
5 years ago (2015-11-26 09:57:32 UTC) #8
Michael Lippautz
https://codereview.chromium.org/1470253002/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1470253002/diff/20001/src/heap/mark-compact.cc#newcode3151 src/heap/mark-compact.cc:3151: IterateLiveObjectsOnPage(p, &new_space_visitor, kClearMarkbits); On 2015/11/26 09:57:32, Hannes Payer wrote: ...
5 years ago (2015-11-26 14:56:28 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470253002/60001
5 years ago (2015-11-26 15:09:41 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12383)
5 years ago (2015-11-26 15:14:17 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470253002/80001
5 years ago (2015-11-26 15:16:07 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 16:01:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470253002/80001
5 years ago (2015-11-26 16:10:11 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-26 16:14:32 UTC) #21
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 Cr-Commit-Position: refs/heads/master@{#32349}
5 years ago (2015-11-26 16:14:57 UTC) #23
Hannes Payer (out of office)
5 years ago (2015-12-01 13:29:58 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1483393002/ by hpayer@chromium.org.

The reason for reverting is: Still investigating bad canary..

Powered by Google App Engine
This is Rietveld 408576698