Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1493503002: base: get rid of deprecated TrimWhitespace() function (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: get rid of deprecated TrimWhitespace() function This patch updates the callers to call TrimWhitespaceASCII() when possible. BUG=None R=brettw@chromium.org Committed: https://crrev.com/023b1dcc012e341a147031d05756666c6b77d29a Cr-Commit-Position: refs/heads/master@{#363369}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : net fix #

Patch Set 4 : chromedriver fix #

Patch Set 5 : fix win? #

Patch Set 6 : net/test fix #

Patch Set 7 : convert_dict #

Patch Set 8 : safe_browsing_db #

Patch Set 9 : content/child/npapi #

Patch Set 10 : chromeos #

Patch Set 11 : plugins & search_engines #

Patch Set 12 : more fixes #

Patch Set 13 : devtools #

Patch Set 14 : pdf & win fixes #

Patch Set 15 : npapi #

Patch Set 16 : chromeos fix #

Patch Set 17 : more chromeos fixes #

Patch Set 18 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -44 lines) Patch
M base/command_line.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/strings/string_util.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M base/strings/string_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/cpu_data_collector.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_brand_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/hunspell_reader.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_policy_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/prefix_set_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M net/base/filename_util_internal.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
M net/test/python_utils_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M pdf/document_loader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
tfarina
Oh, green trybots finally! This is ready for a review now. PTAL.
5 years ago (2015-12-03 20:45:14 UTC) #2
tfarina
Ping?
5 years ago (2015-12-04 23:16:08 UTC) #3
brettw
lgtm
5 years ago (2015-12-04 23:24:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493503002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493503002/320001
5 years ago (2015-12-04 23:41:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 01:47:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493503002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493503002/320001
5 years ago (2015-12-05 01:56:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 04:01:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493503002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493503002/320001
5 years ago (2015-12-05 10:45:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 12:45:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493503002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493503002/340001
5 years ago (2015-12-05 15:34:16 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 17:36:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493503002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493503002/340001
5 years ago (2015-12-06 13:19:17 UTC) #23
commit-bot: I haz the power
Committed patchset #18 (id:340001)
5 years ago (2015-12-06 13:25:51 UTC) #25
commit-bot: I haz the power
5 years ago (2015-12-06 13:26:53 UTC) #27
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/023b1dcc012e341a147031d05756666c6b77d29a
Cr-Commit-Position: refs/heads/master@{#363369}

Powered by Google App Engine
This is Rietveld 408576698