chrome/browser/net/firefox_proxy_settings.cc - Issue 1493503002: base: get rid of deprecated TrimWhitespace() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/firefox_proxy_settings.cc

Issue 1493503002: base: get rid of deprecated TrimWhitespace() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/google/google_brand_chromeos.cc ('k') | chrome/browser/ui/search_engines/edit_search_engine_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/firefox_proxy_settings.cc

diff --git a/chrome/browser/net/firefox_proxy_settings.cc b/chrome/browser/net/firefox_proxy_settings.cc

index 203d9557f6cef98390ece7109b53116113da26eb..16b3618510c51922c9f3682ef4b1a9302b6abbb4 100644

--- a/chrome/browser/net/firefox_proxy_settings.cc

+++ b/chrome/browser/net/firefox_proxy_settings.cc

@@ -102,7 +102,7 @@ bool ParsePrefFile(const base::FilePath& pref_file,

}

std::string value = line.substr(start_value + 1,

stop_value - start_value - 1);

- base::TrimWhitespace(value, base::TRIM_ALL, &value);

+ base::TrimWhitespaceASCII(value, base::TRIM_ALL, &value);

// Value could be a boolean.

bool is_value_true = base::LowerCaseEqualsASCII(value, "true");

if (is_value_true || base::LowerCaseEqualsASCII(value, "false")) {