Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1493483002: relnote: Refactor stream buffer allocation out into a unique_ptr with a custom deleter. (Closed)

Created:
5 years ago by Zhongyi Shi
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Refactor stream buffer allocation out into a unique_ptr with a custom deleter. No functional change. This is intended to support free listing the stream buffer allocations. Re-merge internal change: 103088826 BUG= Committed: https://crrev.com/2f5f40c57c0151c3089c881949c9f574382ac41a Cr-Commit-Position: refs/heads/master@{#363706}

Patch Set 1 #

Patch Set 2 : net export private #

Patch Set 3 : remove todo #

Patch Set 4 : relnote: Refactor stream buffer allocation out into a unique_ptr with a custom deleter. No function… #

Patch Set 5 : add back a comment for deleter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M net/quic/quic_packet_creator.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 4 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Zhongyi Shi
5 years ago (2015-12-05 00:55:58 UTC) #2
Ryan Hamilton
Is this consistent with the internal implementation? Is this a specific CL that it reflects?
5 years ago (2015-12-05 04:18:44 UTC) #3
Zhongyi Shi
On 2015/12/05 04:18:44, Ryan Hamilton wrote: > Is this consistent with the internal implementation? Is ...
5 years ago (2015-12-07 21:37:18 UTC) #5
Ryan Hamilton
lgtm
5 years ago (2015-12-07 21:45:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493483002/80001
5 years ago (2015-12-07 22:01:34 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-08 02:13:09 UTC) #10
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/2f5f40c57c0151c3089c881949c9f574382ac41a Cr-Commit-Position: refs/heads/master@{#363706}
5 years ago (2015-12-08 02:14:58 UTC) #12
Bence
5 years ago (2015-12-17 17:57:11 UTC) #13
Message was sent while issue was closed.
On 2015/12/08 02:14:58, commit-bot: I haz the power wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/2f5f40c57c0151c3089c881949c9f574382ac41a
> Cr-Commit-Position: refs/heads/master@{#363706}

Please note that according to https://chromium-cpp.appspot.com, unique_ptr is
still not on the whitelist.

Powered by Google App Engine
This is Rietveld 408576698