Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: net/quic/quic_packet_creator.cc

Issue 1493483002: relnote: Refactor stream buffer allocation out into a unique_ptr with a custom deleter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add back a comment for deleter Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.cc
diff --git a/net/quic/quic_packet_creator.cc b/net/quic/quic_packet_creator.cc
index 44c0c37db3ab0df5d3d2bd6daeb199bddc342910..5b989583d079c34debc01fd80d9231a89306a6fd 100644
--- a/net/quic/quic_packet_creator.cc
+++ b/net/quic/quic_packet_creator.cc
@@ -323,8 +323,8 @@ size_t QuicPacketCreator::CreateStreamFrame(QuicStreamId id,
CopyToBuffer(iov, iov_offset, bytes_consumed, buffer.get());
// TODO(zhongyi): figure out the lifetime of data. Crashes on windows only.
StringPiece data(buffer.get(), bytes_consumed);
- *frame =
- QuicFrame(new QuicStreamFrame(id, set_fin, offset, data, buffer.Pass()));
+ *frame = QuicFrame(
+ new QuicStreamFrame(id, set_fin, offset, data, std::move(buffer)));
return bytes_consumed;
}
« no previous file with comments | « no previous file | net/quic/quic_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698