Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 149343003: MIPS: Move failing ASSERT to a more sane place. (Closed)

Created:
6 years, 10 months ago by kilvadyb
Modified:
6 years, 10 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Move failing ASSERT to a more sane place. Port r19095 (caf48ad) Original commit message: Objects can actually be stored into themselves. This fails when no write barrier is needed (eg, the object was just allocated). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
6 years, 10 months ago (2014-02-05 12:59:50 UTC) #1
Paul Lind
Looks like you still need to add this assert to MacroAssembler::RecordWrite(), in order to follow ...
6 years, 10 months ago (2014-02-05 18:54:41 UTC) #2
Paul Lind
I had missed that this was already handled in the !AreAliased assertion. LGTM.
6 years, 10 months ago (2014-02-05 22:24:06 UTC) #3
palfia
6 years, 10 months ago (2014-02-05 22:31:59 UTC) #4
Committed as r19122.

Powered by Google App Engine
This is Rietveld 408576698