Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 149343003: MIPS: Move failing ASSERT to a more sane place. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3983 matching lines...) Expand 10 before | Expand all | Expand 10 after
3994 temp, 3994 temp,
3995 GetRAState(), 3995 GetRAState(),
3996 kSaveFPRegs, 3996 kSaveFPRegs,
3997 OMIT_REMEMBERED_SET, 3997 OMIT_REMEMBERED_SET,
3998 OMIT_SMI_CHECK); 3998 OMIT_SMI_CHECK);
3999 } 3999 }
4000 } 4000 }
4001 4001
4002 // Do the store. 4002 // Do the store.
4003 Register value = ToRegister(instr->value()); 4003 Register value = ToRegister(instr->value());
4004 ASSERT(!object.is(value));
4005 SmiCheck check_needed = 4004 SmiCheck check_needed =
4006 instr->hydrogen()->value()->IsHeapObject() 4005 instr->hydrogen()->value()->IsHeapObject()
4007 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 4006 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
4008 if (access.IsInobject()) { 4007 if (access.IsInobject()) {
4009 MemOperand operand = FieldMemOperand(object, offset); 4008 MemOperand operand = FieldMemOperand(object, offset);
4010 __ Store(value, operand, representation); 4009 __ Store(value, operand, representation);
4011 if (instr->hydrogen()->NeedsWriteBarrier()) { 4010 if (instr->hydrogen()->NeedsWriteBarrier()) {
4012 // Update the write barrier for the object for in-object properties. 4011 // Update the write barrier for the object for in-object properties.
4013 __ RecordWriteField(object, 4012 __ RecordWriteField(object,
4014 offset, 4013 offset,
(...skipping 1715 matching lines...) Expand 10 before | Expand all | Expand 10 after
5730 __ Subu(scratch, result, scratch); 5729 __ Subu(scratch, result, scratch);
5731 __ lw(result, FieldMemOperand(scratch, 5730 __ lw(result, FieldMemOperand(scratch,
5732 FixedArray::kHeaderSize - kPointerSize)); 5731 FixedArray::kHeaderSize - kPointerSize));
5733 __ bind(&done); 5732 __ bind(&done);
5734 } 5733 }
5735 5734
5736 5735
5737 #undef __ 5736 #undef __
5738 5737
5739 } } // namespace v8::internal 5738 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698