Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 14934008: Adding unit test for two new functions in mime_util.h/cc. (Closed)

Created:
7 years, 7 months ago by Henrik Grunell
Modified:
7 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Adding unit test for two new functions in mime_util.h/cc. New functions were added in https://chromiumcodereview.appspot.com/15076008/ BUG=229829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200789

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review nit fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M net/base/mime_util_unittest.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Henrik Grunell
7 years, 7 months ago (2013-05-16 08:58:54 UTC) #1
wtc
Patch set 1 LGTM. Thanks. https://codereview.chromium.org/14934008/diff/1/net/base/mime_util_unittest.cc File net/base/mime_util_unittest.cc (right): https://codereview.chromium.org/14934008/diff/1/net/base/mime_util_unittest.cc#newcode311 net/base/mime_util_unittest.cc:311: post_data.clear(); Nit: it would ...
7 years, 7 months ago (2013-05-16 18:24:22 UTC) #2
Henrik Grunell
https://chromiumcodereview.appspot.com/14934008/diff/1/net/base/mime_util_unittest.cc File net/base/mime_util_unittest.cc (right): https://chromiumcodereview.appspot.com/14934008/diff/1/net/base/mime_util_unittest.cc#newcode311 net/base/mime_util_unittest.cc:311: post_data.clear(); On 2013/05/16 18:24:22, wtc wrote: > > Nit: ...
7 years, 7 months ago (2013-05-17 07:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/14934008/5001
7 years, 7 months ago (2013-05-17 07:49:29 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 11:38:07 UTC) #5
Message was sent while issue was closed.
Change committed as 200789

Powered by Google App Engine
This is Rietveld 408576698