Adding unit test for two new functions in mime_util.h/cc.

net/base/mime_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/strings/string_split.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/mime_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 278 matching lines @@
 #else
   EXPECT_EQ(CERTIFICATE_MIME_TYPE_UNKNOWN,
             GetCertificateMimeTypeForMimeType("application/x-x509-ca-cert"));
   EXPECT_EQ(CERTIFICATE_MIME_TYPE_UNKNOWN,
             GetCertificateMimeTypeForMimeType("application/x-pkcs12"));
 #endif
   EXPECT_EQ(CERTIFICATE_MIME_TYPE_UNKNOWN,
             GetCertificateMimeTypeForMimeType("text/plain"));
 }
 
+TEST(MimeUtilTest, TestAddMultipartValueForUpload) {
+  const char* ref_output = "--boundary\r\nContent-Disposition: form-data;"
+                           " name=\"value name\"\r\nContent-Type: content type"
+                           "\r\n\r\nvalue\r\n";
+  std::string post_data;
+  AddMultipartValueForUpload("value name", "value", "boundary",
+                             "content type", &post_data);
+  EXPECT_STREQ(ref_output, post_data.c_str());
+
+  const char* ref_output_no_content_type =
+      "--boundary\r\nContent-Disposition: form-data;"
+      " name=\"value name\"\r\n\r\nvalue\r\n";
+  post_data.clear();

[wtc, 2013/05/16 18:24:22]

Nit: it would be better to test two AddMultipartValueForUpload
calls, without this post_data.clear() call in between,
and just check the combined result once.

I would probably also include the AddMultipartFinalDelimiterForUpload
call in this unit test and omit the next unit test.

[Henrik Grunell, 2013/05/17 07:49:12]

Done.

+  AddMultipartValueForUpload("value name", "value", "boundary",
+                             "", &post_data);
+  EXPECT_STREQ(ref_output_no_content_type, post_data.c_str());
+}
+
+TEST(MimeUtilTest, TestAddMultipartFinalDelimiterForUpload) {
+  const char* ref_output = "--boundary--\r\n";
+  std::string post_data;
+  AddMultipartFinalDelimiterForUpload("boundary", &post_data);
+  EXPECT_STREQ(ref_output, post_data.c_str());
+}
+
 }  // namespace net