Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1493393002: Revert "Use WeakCells in the optimized code map rather than traversing in pause." (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Use WeakCells in the optimized code map rather than traversing in pause." Reason for revert: Probably causes GC stress test failures. TBR=mvstanton@chromium.org BUG= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/39b207ddacad95b9ff98cc94a3baa6335e256519 Cr-Commit-Position: refs/heads/master@{#32574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -113 lines) Patch
M src/code-stubs-hydrogen.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +73 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +25 lines, -0 lines 0 comments Download
M src/objects.cc View 9 chunks +37 lines, -83 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493393002/1
5 years ago (2015-12-03 16:03:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 16:04:10 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 16:04:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39b207ddacad95b9ff98cc94a3baa6335e256519
Cr-Commit-Position: refs/heads/master@{#32574}

Powered by Google App Engine
This is Rietveld 408576698