Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: src/objects-inl.h

Issue 1493393002: Revert "Use WeakCells in the optimized code map rather than traversing in pause." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 418df559da2480230dd6e3b6e5d813a6b146f6d9..c510730b8c65f88861d5116264d0a5f9bb832c19 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2030,10 +2030,7 @@ Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }
void WeakCell::clear() {
- // Either the garbage collector is clearing the cell or we are simply
- // initializing the root empty weak cell.
- DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT ||
- this == GetHeap()->empty_weak_cell());
+ DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT);
WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698