Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1493373003: GetKeys(): Revert all-can-read behavior for Object.keys until LayoutTests are fixed (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GetKeys(): Revert all-can-read behavior for Object.keys until LayoutTests are fixed Committed: https://crrev.com/b24242156b4461b5b3f3a56b739eb69647d3d794 Cr-Commit-Position: refs/heads/master@{#32592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
lgtm
5 years ago (2015-12-03 21:07:21 UTC) #2
Jakob Kummerow
Toon: PTAL Michael: This should greenify LayoutTests, so you can stop reverting innocent CLs ;-)
5 years ago (2015-12-03 21:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493373003/1
5 years ago (2015-12-03 21:08:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 22:34:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b24242156b4461b5b3f3a56b739eb69647d3d794 Cr-Commit-Position: refs/heads/master@{#32592}
5 years ago (2015-12-03 22:35:38 UTC) #8
Michael Achenbach
5 years ago (2015-12-04 08:02:13 UTC) #9
Message was sent while issue was closed.
On 2015/12/03 21:08:08, Jakob wrote:
> Toon: PTAL
> 
> Michael: This should greenify LayoutTests, so you can stop reverting innocent
> CLs ;-)

Yea, thanks! I might have gotten to this at some point :)

Powered by Google App Engine
This is Rietveld 408576698