Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: src/objects.cc

Issue 1493373003: GetKeys(): Revert all-can-read behavior for Object.keys until LayoutTests are fixed (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 13b3918332a888f85a7318f23285fedf9fa52d93..16f7e6f31994820010d2e9c9ac7531bef7ec0925 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -8191,6 +8191,11 @@ static bool GetKeysFromJSObject(Isolate* isolate, Handle<JSReceiver> receiver,
DCHECK(type == JSReceiver::OWN_ONLY);
filter = static_cast<PropertyFilter>(filter | ONLY_ALL_CAN_READ);
keep_going = false;
+
+ // TODO(jkummerow): LayoutTests need adaptation before we can be spec
+ // compliant.
+ // Let [[OwnPropertyKeys]] also return an empty list for now.
+ return false;
}
JSObject::CollectOwnElementKeys(object, accumulator, filter);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698