Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1493283002: Reland of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (Closed)

Created:
5 years ago by Adrian Kuegel
Modified:
5 years ago
Reviewers:
Nico, krasin
CC:
chromium-reviews, pcc, kcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1494883004/ ) Reason for revert: Reverting didn't help. Original issue's description: > Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ ) > > Reason for revert: > This breaks Codesearch bots. > > Original issue's description: > > Fix downloading LLVM Gold plugin in the case, when Clang is up to date. > > > > The script should download LLVM Gold plugin, if it's missing, even if the > > main Clang toolchain is up to date. This change is to match update.py > > functionality with the gone update.sh. > > > > BUG=464797, 494442 > > > > Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3 > > Cr-Commit-Position: refs/heads/master@{#362803} > > TBR=thakis@chromium.org,krasin@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=464797, 494442 > > Committed: https://crrev.com/9e37ffbe43c0b100bcc02f9faf648f11d86316c1 > Cr-Commit-Position: refs/heads/master@{#362938} TBR=thakis@chromium.org,krasin@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464797, 494442 Committed: https://crrev.com/2f8494c55755a5b7f7c61c5204b05a5634189b3c Cr-Commit-Position: refs/heads/master@{#362939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M tools/clang/scripts/update.py View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Adrian Kuegel
Created Reland of Fix downloading LLVM Gold plugin in the case, when Clang is up ...
5 years ago (2015-12-03 10:12:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493283002/1
5 years ago (2015-12-03 10:12:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 10:14:00 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 10:15:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f8494c55755a5b7f7c61c5204b05a5634189b3c
Cr-Commit-Position: refs/heads/master@{#362939}

Powered by Google App Engine
This is Rietveld 408576698