Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1491203003:
Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (Closed)
DescriptionFix downloading LLVM Gold plugin in the case, when Clang is up to date.
The script should download LLVM Gold plugin, if it's missing, even if the
main Clang toolchain is up to date. This change is to match update.py
functionality with the gone update.sh.
BUG=464797, 494442
Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
Cr-Commit-Position: refs/heads/master@{#362803}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 22 (10 generated)
krasin@google.com changed reviewers: + thakis@chromium.org
Description was changed from ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797 ========== to ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797,494442 ==========
lgtm, thanks I added a bug to the BUG= line
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491203003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491203003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491203003/1
Message was sent while issue was closed.
Description was changed from ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797,494442 ========== to ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797,494442 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797,494442 ========== to ========== Fix downloading LLVM Gold plugin in the case, when Clang is up to date. The script should download LLVM Gold plugin, if it's missing, even if the main Clang toolchain is up to date. This change is to match update.py functionality with the gone update.sh. BUG=464797,494442 Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3 Cr-Commit-Position: refs/heads/master@{#362803} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3 Cr-Commit-Position: refs/heads/master@{#362803}
Message was sent while issue was closed.
akuegel@chromium.org changed reviewers: + akuegel@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1491203003/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1491203003/diff/1/tools/clang/scripts/update.... tools/clang/scripts/update.py:311: print 'Clang is already up to date.' I think this early return breaks the case if you want to compile clang tools, like we do on the Codesearch bots: https://build.chromium.org/p/chromium.infra.cron/builders/Chromium%20Linux%20... Look at the "compile translation_unit clang tool" step, it does an early return while in fact it should compile the clang tool.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1494883004/ by akuegel@chromium.org. The reason for reverting is: This breaks Codesearch bots..
Message was sent while issue was closed.
On 2015/12/03 09:29:40, Adrian Kuegel wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1494883004/ by mailto:akuegel@chromium.org. > > The reason for reverting is: This breaks Codesearch bots.. Sorry, in the hurry I didn't notice that you were trying to fix the same issue for your use case that the Codesearch bots run into. I relanded it now. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
