Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1493133003: [heap] Fix finalization of incremental marking race. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix finalization of incremental marking race. Between requesting finalization of incremental marking and the time where we handle the request in the stack guard, the current full GC may have finished. In that case the stack guard triggers to late and tries to finalize marking in a state where marking is not going on. Note that a cleaner fix would be to express the finalization phase in a special marking phase. I will do that in a follow-up CL. BUG= Committed: https://crrev.com/4f2009eb39a4a69ca61f5ca7aa09c972aeb9479a Cr-Commit-Position: refs/heads/master@{#32552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Hannes Payer (out of office)
5 years ago (2015-12-03 11:34:21 UTC) #3
ulan
lgtm
5 years ago (2015-12-03 11:36:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493133003/1
5 years ago (2015-12-03 11:36:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 12:09:48 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 12:10:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f2009eb39a4a69ca61f5ca7aa09c972aeb9479a
Cr-Commit-Position: refs/heads/master@{#32552}

Powered by Google App Engine
This is Rietveld 408576698