Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/heap/heap.cc

Issue 1493133003: [heap] Fix finalization of incremental marking race. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index e1fa2fcf22579e5f6f7014725a8e617ed3e709b3..cbfe24b4921e4a8fea36976a439770b56a06b7f6 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -764,7 +764,8 @@ void Heap::HandleGCRequest() {
return;
}
DCHECK(FLAG_finalize_marking_incrementally);
- if (!incremental_marking()->finalize_marking_completed()) {
+ if (incremental_marking()->IsMarking() &&
+ !incremental_marking()->finalize_marking_completed()) {
FinalizeIncrementalMarking("GC interrupt: finalize incremental marking");
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698