Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1492983002: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. The optimized code generated by Crankshaft cannot properly deal with proxies (in the prototype chain), and there's probably no point in trying to make that work^Wfast with Crankshaft at all. TurboFan will handle that properly; Crankshaft just bails out to fullcodegen, which then goes to the runtime, which should do the right thing soon. BUG=v8:1543 LOG=n Committed: https://crrev.com/a330af0ed1f237ba17ac2242ce16cad5616c0597 Cr-Commit-Position: refs/heads/master@{#32539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492983002/1
5 years ago (2015-12-03 04:51:24 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 05:00:39 UTC) #4
Benedikt Meurer
Hey Yang, Easy fix to make Crankshaft bailout on proxies. Please take a look. Thanks, ...
5 years ago (2015-12-03 06:14:22 UTC) #6
Yang
On 2015/12/03 06:14:22, Benedikt Meurer wrote: > Hey Yang, > > Easy fix to make ...
5 years ago (2015-12-03 06:17:23 UTC) #7
Yang
On 2015/12/03 06:14:22, Benedikt Meurer wrote: > Hey Yang, > > Easy fix to make ...
5 years ago (2015-12-03 06:17:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492983002/1
5 years ago (2015-12-03 06:18:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 06:22:24 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 06:22:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a330af0ed1f237ba17ac2242ce16cad5616c0597
Cr-Commit-Position: refs/heads/master@{#32539}

Powered by Google App Engine
This is Rietveld 408576698