src/crankshaft/x64/lithium-codegen-x64.cc - Issue 1492983002: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 1492983002: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 274e3b87201ac3e0ad54a2a8b1969bca773d9a4d..1201adc3bab71ac9d4a810096e87963b723e7f8a 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -2656,6 +2656,8 @@ void LCodeGen::DoHasInPrototypeChainAndBranch(

__ movp(object_map, FieldOperand(object, HeapObject::kMapOffset));

Label loop;

__ bind(&loop);

+ __ CmpInstanceType(object_map, JS_PROXY_TYPE);

+ DeoptimizeIf(equal, instr, Deoptimizer::kProxy);

__ movp(object_prototype, FieldOperand(object_map, Map::kPrototypeOffset));

__ cmpp(object_prototype, prototype);

EmitTrueBranch(instr, equal);

« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.cc ('k') | src/crankshaft/x64/lithium-x64.cc » ('j') | no next file with comments »