Add command line overrides for GCM checkin URL & MCS endpoint

Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760

Committed: https://crrev.com/099ee16b53faf5ef41783b04c65cfebfd4fba9ea
Cr-Commit-Position: refs/heads/master@{#362965}

[johnme, 2015-12-02 18:41:17]

johnme@chromium.org changed reviewers:
+ fgorski@chromium.org

[johnme, 2015-12-02 18:42:15]

Description was changed from

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760
==========

to

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760
==========

[johnme, 2015-12-02 18:42:15]

johnme@chromium.org changed reviewers:
- fgorski@chromium.org

[johnme, 2015-12-02 18:42:49]

johnme@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-12-02 19:48:22]

lgtm

https://codereview.chromium.org/1492913002/diff/1/components/gcm_driver/gcm_c...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/1492913002/diff/1/components/gcm_driver/gcm_c...
components/gcm_driver/gcm_client_impl.cc:482: if (endpoints[1].is_empty())
nit: I think it would be cleaner to do
GURL fallback_endpoint = gservices...;
if (fallback_endpoint.is_valid())
  endpoints.push_back(...)

[johnme, 2015-12-03 12:22:49]

Addressed nit - thanks :)

https://codereview.chromium.org/1492913002/diff/1/components/gcm_driver/gcm_c...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/1492913002/diff/1/components/gcm_driver/gcm_c...
components/gcm_driver/gcm_client_impl.cc:482: if (endpoints[1].is_empty())
On 2015/12/02 19:48:21, Nicolas Zea wrote:
> nit: I think it would be cleaner to do
> GURL fallback_endpoint = gservices...;
> if (fallback_endpoint.is_valid())
>   endpoints.push_back(...)

Done.

[johnme, 2015-12-03 12:22:54]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-12-03 12:22:55]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1492913002/#ps20001
(title: "Review nit")

[commit-bot: I haz the power, 2015-12-03 12:23:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492913002/20001

[commit-bot: I haz the power, 2015-12-03 13:00:49]

Description was changed from

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760
==========

to

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760
==========

[commit-bot: I haz the power, 2015-12-03 13:00:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 13:02:02]

Description was changed from

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760
==========

to

==========
Add command line overrides for GCM checkin URL & MCS endpoint

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760

Committed: https://crrev.com/099ee16b53faf5ef41783b04c65cfebfd4fba9ea
Cr-Commit-Position: refs/heads/master@{#362965}
==========

[commit-bot: I haz the power, 2015-12-03 13:02:03]

Patchset 2 (id:??) landed as
https://crrev.com/099ee16b53faf5ef41783b04c65cfebfd4fba9ea
Cr-Commit-Position: refs/heads/master@{#362965}