Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/gcm_driver/gcm_client_impl.cc

Issue 1492913002: Add command line overrides for GCM checkin URL & MCS endpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review nit Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gcm/engine/gservices_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_client_impl.cc
diff --git a/components/gcm_driver/gcm_client_impl.cc b/components/gcm_driver/gcm_client_impl.cc
index 9c4c6ad05870240443ce628a43c06e39c7337fb6..b576b23461a57a93af3f49c51dc328a6b1432f2d 100644
--- a/components/gcm_driver/gcm_client_impl.cc
+++ b/components/gcm_driver/gcm_client_impl.cc
@@ -478,7 +478,9 @@ void GCMClientImpl::StartGCM() {
void GCMClientImpl::InitializeMCSClient() {
std::vector<GURL> endpoints;
endpoints.push_back(gservices_settings_.GetMCSMainEndpoint());
- endpoints.push_back(gservices_settings_.GetMCSFallbackEndpoint());
+ GURL fallback_endpoint = gservices_settings_.GetMCSFallbackEndpoint();
+ if (fallback_endpoint.is_valid())
+ endpoints.push_back(fallback_endpoint);
connection_factory_ = internals_builder_->BuildConnectionFactory(
endpoints,
GetGCMBackoffPolicy(),
« no previous file with comments | « no previous file | google_apis/gcm/engine/gservices_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698