Issue 1492823003: fix most gn check issues in //ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1492823003: fix most gn check issues in //ui (Closed)

Created:
5 years ago by jbroman

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews, tapted, sadrul, Matt Giuca, tdresser+watch_chromium.org, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-check-blink-source

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

fix most gn check issues in //ui BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -0 lines)			Patch
M	ui/app_list/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/BUILD.gn	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/compositor/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/events/BUILD.gn	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/gfx/BUILD.gn	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/gl/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/keyboard/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/platform_window/BUILD.gn	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/platform_window/stub/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/BUILD.gn	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/wm/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1491333002 Patch 1