Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1491333002: Include //third_party/WebKit/Source/* in default gn check targets. (Closed)

Created:
5 years ago by jbroman
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include //third_party/WebKit/Source/* in default gn check targets. It checks cleanly, even though //third_party/WebKit/public does not. Committed: https://crrev.com/626eecf82054e5c47bfa987a5622918d56557cbc Cr-Commit-Position: refs/heads/master@{#363027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
jbroman
As far as I can tell, //third_party/WebKit/Source/* (notably not including public/) passes `gn check`. Any ...
5 years ago (2015-12-03 18:37:14 UTC) #2
brettw
lgtm
5 years ago (2015-12-03 18:50:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491333002/1
5 years ago (2015-12-03 18:52:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:59:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 18:59:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/626eecf82054e5c47bfa987a5622918d56557cbc
Cr-Commit-Position: refs/heads/master@{#363027}

Powered by Google App Engine
This is Rietveld 408576698