[fullcode] Switch passing of new.target to register.

[fullcode] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that this marks the last
consumer of said side-channel and the special slot in the construct
stub frame can be removed as a follow-up.

R=bmeurer@chromium.org,yangguo@chromium.org
TEST=mjsunit/es6/regress/regress-new-target-context

Committed: https://crrev.com/440a42b74135b84c188d7db11f4c07678f53d0f3
Cr-Commit-Position: refs/heads/master@{#32548}

[Michael Starzinger, 2015-12-02 12:34:59]

Note that ports are not yet done, but I would like to get a first round of
feedback before I do the ports.

[Benedikt Meurer, 2015-12-02 12:36:08]

Approach looks good, I like it.

https://codereview.chromium.org/1492793002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1492793002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:179:
DCHECK(info->scope()->new_target_var() == nullptr);
Nit: DCHECK_NULL.

[Michael Starzinger, 2015-12-02 13:59:00]

Thanks! Doing ports now.

https://codereview.chromium.org/1492793002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1492793002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:179:
DCHECK(info->scope()->new_target_var() == nullptr);
On 2015/12/02 12:36:08, Benedikt Meurer wrote:
> Nit: DCHECK_NULL.

Done.

[Yang, 2015-12-02 14:02:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 14:03:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492793002/20001

[commit-bot: I haz the power, 2015-12-02 14:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 14:28:58]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-12-02 14:45:47]

PTAL. Ports done. Ready for final review.

[Benedikt Meurer, 2015-12-02 15:35:23]

On 2015/12/02 14:45:47, Michael Starzinger wrote:
> PTAL. Ports done. Ready for final review.

LGTM. Thanks Michi for doing the new.target yak shaving!

[Michael Starzinger, 2015-12-03 09:36:00]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-03 09:36:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492793002/40001

[commit-bot: I haz the power, 2015-12-03 10:04:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-03 10:04:41]

Description was changed from

==========
[fullcode] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that this marks the last
consumer of said side-channel and the special slot in the construct
stub frame can be removed as a follow-up.

R=bmeurer@chromium.org,yangguo@chromium.org
TEST=mjsunit/es6/regress/regress-new-target-context
==========

to

==========
[fullcode] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that this marks the last
consumer of said side-channel and the special slot in the construct
stub frame can be removed as a follow-up.

R=bmeurer@chromium.org,yangguo@chromium.org
TEST=mjsunit/es6/regress/regress-new-target-context

Committed: https://crrev.com/440a42b74135b84c188d7db11f4c07678f53d0f3
Cr-Commit-Position: refs/heads/master@{#32548}
==========

[commit-bot: I haz the power, 2015-12-03 10:04:42]

Patchset 3 (id:??) landed as
https://crrev.com/440a42b74135b84c188d7db11f4c07678f53d0f3
Cr-Commit-Position: refs/heads/master@{#32548}