Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1489353004: Remove new.target value from construct stub frames. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-pass-new-target-9
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove new.target value from construct stub frames. This drops the specific slot containing the new.target value from our construct stub frames. This side-channel has been deprecated and will no longer be accessed by any consumers. R=verwaest@chromium.org Committed: https://crrev.com/eaa0e59611f437568a81d76b4d7d446b0d4786a6 Cr-Commit-Position: refs/heads/master@{#32550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -74 lines) Patch
M src/arm/builtins-arm.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/frames.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-12-02 15:58:20 UTC) #1
Toon Verwaest
lgtm
5 years ago (2015-12-03 11:23:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489353004/1
5 years ago (2015-12-03 11:25:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 11:33:21 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-03 11:33:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaa0e59611f437568a81d76b4d7d446b0d4786a6
Cr-Commit-Position: refs/heads/master@{#32550}

Powered by Google App Engine
This is Rietveld 408576698