Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2904)

Unified Diff: android_webview/native/aw_settings.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_settings.h
diff --git a/android_webview/native/aw_settings.h b/android_webview/native/aw_settings.h
index 56b09ad10b5f8e92a1b4f15f339d144a2629ff03..79d4f758daee8e47b122d28a89481eabf9e3c9cc 100644
--- a/android_webview/native/aw_settings.h
+++ b/android_webview/native/aw_settings.h
@@ -29,16 +29,33 @@ class AwSettings : public content::WebContentsObserver {
// Called from Java. Methods with "Locked" suffix require that the settings
// access lock is held during their execution.
- void Destroy(JNIEnv* env, jobject obj);
- void PopulateWebPreferencesLocked(JNIEnv* env, jobject obj, jlong web_prefs);
- void ResetScrollAndScaleState(JNIEnv* env, jobject obj);
- void UpdateEverythingLocked(JNIEnv* env, jobject obj);
- void UpdateInitialPageScaleLocked(JNIEnv* env, jobject obj);
- void UpdateUserAgentLocked(JNIEnv* env, jobject obj);
- void UpdateWebkitPreferencesLocked(JNIEnv* env, jobject obj);
- void UpdateFormDataPreferencesLocked(JNIEnv* env, jobject obj);
- void UpdateRendererPreferencesLocked(JNIEnv* env, jobject obj);
- void UpdateOffscreenPreRasterLocked(JNIEnv* env, jobject obj);
+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void PopulateWebPreferencesLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jlong web_prefs);
+ void ResetScrollAndScaleState(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateEverythingLocked(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateInitialPageScaleLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateUserAgentLocked(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateWebkitPreferencesLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateFormDataPreferencesLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateRendererPreferencesLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void UpdateOffscreenPreRasterLocked(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
void PopulateWebPreferences(content::WebPreferences* web_prefs);
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698