Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: android_webview/native/aw_quota_manager_bridge_impl.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.h ('k') | android_webview/native/aw_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_quota_manager_bridge_impl.cc
diff --git a/android_webview/native/aw_quota_manager_bridge_impl.cc b/android_webview/native/aw_quota_manager_bridge_impl.cc
index abf791ea49ffee2f51bfa589ee45c63d2f293671..d4ae0cd706f395306c68a285de044e91c553683e 100644
--- a/android_webview/native/aw_quota_manager_bridge_impl.cc
+++ b/android_webview/native/aw_quota_manager_bridge_impl.cc
@@ -180,7 +180,8 @@ AwQuotaManagerBridgeImpl::AwQuotaManagerBridgeImpl(
AwQuotaManagerBridgeImpl::~AwQuotaManagerBridgeImpl() {}
-void AwQuotaManagerBridgeImpl::Init(JNIEnv* env, jobject object) {
+void AwQuotaManagerBridgeImpl::Init(JNIEnv* env,
+ const JavaParamRef<jobject>& object) {
java_ref_ = JavaObjectWeakGlobalRef(env, object);
}
@@ -202,7 +203,9 @@ QuotaManager* AwQuotaManagerBridgeImpl::GetQuotaManager() const {
return quota_manager;
}
-void AwQuotaManagerBridgeImpl::DeleteAllData(JNIEnv* env, jobject object) {
+void AwQuotaManagerBridgeImpl::DeleteAllData(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object) {
RunOnUIThread(base::Bind(&AwQuotaManagerBridgeImpl::DeleteAllDataOnUiThread,
this));
}
@@ -222,7 +225,9 @@ void AwQuotaManagerBridgeImpl::DeleteAllDataOnUiThread() {
}
void AwQuotaManagerBridgeImpl::DeleteOrigin(
- JNIEnv* env, jobject object, jstring origin) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ const JavaParamRef<jstring>& origin) {
base::string16 origin_string(
base::android::ConvertJavaStringToUTF16(env, origin));
RunOnUIThread(base::Bind(&AwQuotaManagerBridgeImpl::DeleteOriginOnUiThread,
@@ -246,8 +251,9 @@ void AwQuotaManagerBridgeImpl::DeleteOriginOnUiThread(
base::Bind(&base::DoNothing));
}
-void AwQuotaManagerBridgeImpl::GetOrigins(
- JNIEnv* env, jobject object, jint callback_id) {
+void AwQuotaManagerBridgeImpl::GetOrigins(JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ jint callback_id) {
RunOnUIThread(base::Bind(&AwQuotaManagerBridgeImpl::GetOriginsOnUiThread,
this,
callback_id));
@@ -305,8 +311,9 @@ void OnUsageAndQuotaObtained(
} // namespace
void AwQuotaManagerBridgeImpl::GetUsageAndQuotaForOrigin(
- JNIEnv* env, jobject object,
- jstring origin,
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ const JavaParamRef<jstring>& origin,
jint callback_id,
bool is_quota) {
base::string16 origin_string(
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.h ('k') | android_webview/native/aw_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698