android_webview/native/aw_pdf_exporter.h - Issue 1492703004: Pass method parameters as JavaParamRef in android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_pdf_exporter.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_pdf_exporter.h

diff --git a/android_webview/native/aw_pdf_exporter.h b/android_webview/native/aw_pdf_exporter.h

index f2513f82b2fde4d952795bd32f7852ced13a1565..2b44a850db5fc090156fcc5088e3f4f354af536b 100644

--- a/android_webview/native/aw_pdf_exporter.h

+++ b/android_webview/native/aw_pdf_exporter.h

@@ -31,9 +31,9 @@ class AwPdfExporter {

~AwPdfExporter();

void ExportToPdf(JNIEnv* env,

- jobject obj,

+ const base::android::JavaParamRef<jobject>& obj,

int fd,

- jobject cancel_signal);

+ const base::android::JavaParamRef<jobject>& cancel_signal);

private:

void InitPdfSettings(JNIEnv* env,

« no previous file with comments | « android_webview/native/aw_message_port_service_impl.cc ('k') | android_webview/native/aw_pdf_exporter.cc » ('j') | no next file with comments »